Enhancement: Added validation to include
#84
Conversation
Added an extra assertion to check that the include expectation is always called with just one argument. Fixes: hapijs#83
| @@ -2297,7 +2320,8 @@ describe('incomplete()', () => { | |||
|
|
|||
| const a = Code.expect(1).to; | |||
| Code.expect(2).to.equal(2); | |||
| Hoek.assert(Code.incomplete().length === 1); | |||
| const actual = Code.incomplete(); | |||
| Hoek.assert(actual.length === 1, actual); | |||
There was a problem hiding this comment.
I'm not sure that just showing actual is any more meaningful.
There was a problem hiding this comment.
Sorry, didn't mean to make this change. I'll revert it.
Fix as per [Pull request 84](hapijs#84)
| @@ -1124,6 +1124,52 @@ describe('expect()', () => { | |||
| Hoek.assert(!exception, exception); | |||
| done(); | |||
| }); | |||
|
|
|||
| const tests = [ | |||
There was a problem hiding this comment.
This isn't what I meant. One it() block. No tests array. No loop. You can just use curly braces to define a scope and do a simple test inside of it so you can reuse the same variable names. See https://github.com/nodejs/node/blob/4a408321d9c4a6964c9d89a0dd09067f36b4dbfc/test/parallel/test-vm-debug-context.js#L34-L72 as an example.
Second refactor to fix tests as per [Pull request 84](hapijs#84)
| Hoek.assert(exception.message === 'Can only assert include with a single parameter', exception); | ||
| } | ||
|
|
||
| { |
There was a problem hiding this comment.
I think this second test can be dropped, as the functionality is tested elsewhere.
|
One last comment, then this is good to go. |
> I think this second test can be dropped, as the functionality is > tested elsewhere. > --cjihrig
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Added an extra assertion to check that the
includeexpectation is alwayscalled with just one argument.
Fixes: #83