Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release? #91

Closed
blacksun1 opened this issue Sep 19, 2016 · 6 comments
Closed

New release? #91

blacksun1 opened this issue Sep 19, 2016 · 6 comments
Assignees
@cjihrig
Labels
non issue Issue is not a problem or requires changes support Questions, discussions, and general support
Milestone
4.0.0

Comments

@blacksun1
Copy link
Contributor

Hi, There has been a bunch of new changes made to code over the last few weeks at least. Can these please be released to NPM soon? There hasn't been a release since July.

Thanks in advance,
@cjihrig
Copy link
Contributor

cjihrig commented Sep 19, 2016

I was trying to avoid bumping the major too soon after the 3.0.0 release, which was on May 20th. Looking at the 4.0.0 milestone, #84 and #77 are the only changes to lib/ code - amounting to two low priority changes and two total lines of code changed. That said, 4 months is plenty of time between major releases, so I'll most likely do a release this week.

@cjihrig cjihrig added non issue Issue is not a problem or requires changes support Questions, discussions, and general support labels Sep 19, 2016
@cjihrig cjihrig self-assigned this Sep 19, 2016
@blacksun1
Copy link
Contributor Author

Maybe we should see what if anything happens with Hoek issue number 196 (contain doesn't support non-enumerable properties defined with defineProperties) as well.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 19, 2016

Looks like that Hoek PR was merged and published in 4.1.0, so it will automatically get picked up here.

@blacksun1
Copy link
Contributor Author

Haha. Yeah, that happened just a few minutes ago - after I wrote that comment.

@cjihrig cjihrig added this to the 4.0.0 milestone Sep 21, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 21, 2016

v4.0.0 is published.

@cjihrig cjihrig closed this as completed Sep 21, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cjihrig cjihrig

Labels
non issue Issue is not a problem or requires changes support Questions, discussions, and general support
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@blacksun1 @cjihrig