-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose() returns a Promise if no callback is provided #54
Conversation
Well, supporting Promise in Glue is related to Hapi v12.0.0 supporting Promise. That's why I updated the dependency and the Readme. |
Anything else? I will do a "force push" to get proper history. |
What about |
You're right, I am not a big fan of this extra file either. |
Thanks for the pointer on Hapi 12 supporting promises, and the relationship there. I see that is where the abstract promises.js module came from as well - but since we only have a single use, I think we can do without it. |
That's all the feedback I have right now. Thanks. |
Oh. The API.md document needs to be updated as well. |
I've pushed a commit on top of yours to a 'promises' branch. Please review and let me know if you have any further changes or concerns with the changes I made. Feel free to squash the commit into yours and force push, or it can go out as is. |
Clean up promises.
Done ;-) |
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
No description provided.