Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose() returns a Promise if no callback is provided #54

Merged
merged 1 commit into from
Jan 15, 2016
Merged

compose() returns a Promise if no callback is provided #54

merged 1 commit into from
Jan 15, 2016

Conversation

SimonDegraeve
Copy link
Contributor

No description provided.

@SimonDegraeve
Copy link
Contributor Author

Well, supporting Promise in Glue is related to Hapi v12.0.0 supporting Promise. That's why I updated the dependency and the Readme.

@SimonDegraeve
Copy link
Contributor Author

Anything else? I will do a "force push" to get proper history.

@SimonDegraeve
Copy link
Contributor Author

What about instanceof Error?

@SimonDegraeve
Copy link
Contributor Author

You're right, I am not a big fan of this extra file either.

@csrl
Copy link
Contributor

csrl commented Jan 9, 2016

Thanks for the pointer on Hapi 12 supporting promises, and the relationship there. I see that is where the abstract promises.js module came from as well - but since we only have a single use, I think we can do without it.

@csrl
Copy link
Contributor

csrl commented Jan 9, 2016

That's all the feedback I have right now. Thanks.

@csrl
Copy link
Contributor

csrl commented Jan 9, 2016

Oh. The API.md document needs to be updated as well.

@csrl
Copy link
Contributor

csrl commented Jan 9, 2016

I've pushed a commit on top of yours to a 'promises' branch. Please review and let me know if you have any further changes or concerns with the changes I made. Feel free to squash the commit into yours and force push, or it can go out as is.

@csrl csrl mentioned this pull request Jan 9, 2016
@csrl csrl added the feature New functionality or improvement label Jan 9, 2016
@csrl csrl added this to the 3.1.0 milestone Jan 9, 2016
@csrl csrl self-assigned this Jan 9, 2016
@SimonDegraeve
Copy link
Contributor Author

Done ;-)

@csrl csrl merged commit 247f5c7 into hapijs:master Jan 15, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants