Promise wrapper

[gergoerdosi]

What do you think about moving the promise wrapper (https://github.com/hapijs/hapi/blob/master/lib/promises.js) from hapi to hoek? Other modules could then easily reuse this code. For example: hapijs/glue#54.

[devinivy]

I like that idea.

[csrl]

The idea is good, but the specific implementation expects the callback to always have a single parameter which is determined to be either the result or an error depending on whether it is an Error instance or not. Most callback handlers have the form of => (err, result), so that should be taken into consideration.

[hueniverse]

I'm open to it if we keep it as simple.

[nlf]

i'll get this in the next release, i think i know how i want to do it though. the main question i have is do we anticipate people only wrapping things in promises that accept two parameters to the callback?

what about things like wreck.get() which pass 3 parameters to the callback? should the promise resolve with an array containing the last two params?

[catalint]

I've just now seen this discussion ... ignore pr #187 until we settle on this

[catalint]

propsed something that could work for multiple params, you can take a look at #188

it's quite general, maybe we should by default expect a callback to look like this callback(err,value) instead of the current callback(err|value) ?

[catalint]

hi guys, could I help more to get this to the finish line?

[nlf]

closing this, IMO the use cases here are too varied to get it right with one method

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.