Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve API docs in README; add types, improve formatting #89

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

BlooJeans
Copy link
Contributor

Updates the docs to be a little more structured + have typedefs included for those so inclined
Also brings it closer in parity to pino's docs ( https://github.com/pinojs/pino/blob/master/docs/api.md#pinooptions-destination--logger )

Before:
Screenshot_20191028_143322

After:
Screenshot_20191028_143255

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.018% when pulling 8f26957 on devshackio:readme-improve-api-docs into 02ce38b on pinojs:master.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

@mcollina mcollina merged commit 9b84037 into hapijs:master Oct 29, 2019
@BlooJeans BlooJeans deleted the readme-improve-api-docs branch October 29, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants