Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty or falsy charset in response #1928

Merged
merged 1 commit into from
Oct 1, 2014

Conversation

kanongil
Copy link
Contributor

This way it's possible to explicitly remove the charset from the response which can be valid for some use-cases.

@hueniverse
Copy link
Contributor

Why?

@kanongil
Copy link
Contributor Author

@hueniverse Personally I would like to serve text/vtt files, and I was surprised to find that a charset was added to the header. From the standard text/vtt files are required to have utf-8 encoding, thus the charset indicator would only help clients that parse it as plain text which I don't expect to ever have.

@kanongil
Copy link
Contributor Author

Any update on this?

Also, https://tools.ietf.org/html/rfc6838#section-4.2.1 states that the charset "SHOULD NOT" be specified for text content where the charset is already transported in the payload.

@hueniverse hueniverse added feature New functionality or improvement and removed request labels Oct 1, 2014
@hueniverse hueniverse added this to the 6.9.1 milestone Oct 1, 2014
@hueniverse hueniverse self-assigned this Oct 1, 2014
hueniverse pushed a commit that referenced this pull request Oct 1, 2014
Handle empty or falsy charset in response
@hueniverse hueniverse merged commit 84dcf59 into hapijs:master Oct 1, 2014
hueniverse pushed a commit that referenced this pull request Oct 1, 2014
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants