server.dependency: call after with (server, options, next). Closes #2520

[garthk]

This fixes #2520 without breaking any other tests, but I'm not entirely happy with it:

• The arguments list for the Plugin constructor is getting a little long
• That check for ext.arity in Server.start doesn't explain itself
• Plugin.after is getting too clever with its arguments

(Update: cleaned up a little in later commits, now squashed in.)

[garthk]

Heh. Finding those lint errors was tough; I started with the lint branch, which has ~200 lines of lint complaints. Travis had a shorter list, but with line numbers based on master.

[hueniverse]

Can't check the number of arguments in a callback function like this. It is never a good idea because you don't know how the method is implemented internally. It can have more than 3 arguments or no arguments at all and use arguments.

[garthk]

Cleaned up the mess I'd made of _afters by pre-binding the after method's leading arguments. Removed checks against arguments.length as a side-effect. Cost: another private API method.

Any hints on how to rebase to master? I've been using Mercurial for half a decade.

[garthk]

Rebased and squashed. Travis failed for io.js because npm install failed. Re-running the build should clear the error.

FWIW, I won't be at all offended if you ditch the PR because it doesn't pass muster. I'm delighted just to be able to file a PR.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.