Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Chrome Apps and WebExtensions #3946

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Add support for Chrome Apps and WebExtensions #3946

merged 1 commit into from
Sep 13, 2019

Commits on Sep 12, 2019

  1. fix: ReadableStream detection in Chrome Apps 

    Detection via `stream instanceof Stream` does not work correctly in browser context,
especially when different polyfils are used and mixed together.

This change replaces instanceof check with feature-detection of stream-like objects.
It enables Hapi to be used in Chrome Apps (browser environments with additional chrome.sockets APIs)

Real life example:
ipfs/ipfs-companion#664
    @lidel
    lidel committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    0d73f8d View commit details
    Browse the repository at this point in the history