Preserve original response status on error after write, fix status message #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4182 brings-up valid concerns about the status codes reported by
server.inject()for response errors that occur after the original status code and headers have been written. In the past these original status codes have been completely overwritten. Now it should be accessible onserver.inject()'sresponse.raw.res.statusCode, which may differ fromresponse.statusCodewhen an error happened after the status code was written. This work additionally fixesresponse.statusMessage, which was out of sync withresponse.statusCodein these cases.For some history on status codes reported by
server.inject()see also outmoded/discuss#729 #3878 #3561