Fix memory leaks from teamwork long standing notes #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
If someone could test hapi to ensure this fixes the leak that would be excellent, but I followed along and it all looked right to me. Thanks @Nargonath!
|
Thank you @devinivy . I didn't have bandwidth to test it out as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to hapijs/teamwork#32. @kanongil spotted a memory leak on #4343 (comment). The leak stems from
hapi'sserver.ext()method that leverages long standing Teamwork instances when no method are passed for an extension point. Sinceteamworkdidn't clear its internal notes ref once the meeting was over, objects passed toteam.attend()were never garbage collected and it also kept adding notes to an ended meeting.The fix was provided in
@hapi/teamwork@5.1.1thus the PR only updateshapidependency.