Pack: Automatically resolve the requirePath if provided
#835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2013 20:09
ghost
mentioned this pull request
| @@ -30,7 +30,10 @@ exports = module.exports = internals.Pack = function (options) { | |||
|
|
|||
| options = options || {}; | |||
|
|
|||
| Utils.assert(!options || !options.requirePath || options.requirePath[0] === '/', 'Pack option \'requirePath\' must be an absolute path'); | |||
| var requirePath = options.requirePath; | |||
| if (typeof requirePath === 'string') { | |||
There was a problem hiding this comment.
Why check if it is a string? why not just check if it is present?
There was a problem hiding this comment.
I added the type check because path.resolve will throw a TypeError if a non-string argument is provided (previous versions of Node ignored invalid arguments).
There was a problem hiding this comment.
yeah, but that's just a bad config which should throw anyway
There was a problem hiding this comment.
Makes sense—thanks for cleaning it up in 14b7ce3.
hueniverse
pushed a commit
that referenced
this pull request
May 10, 2013
`Pack`: Automatically resolve the `requirePath` if provided
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
`Pack`: Automatically resolve the `requirePath` if provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #834.