-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move .wrap from hapi #187
move .wrap from hapi #187
Conversation
# Conflicts: # README.md # lib/index.js # package.json
@@ -16,8 +16,8 @@ | |||
"lab": "10.x.x" | |||
}, | |||
"scripts": { | |||
"test": "lab -a code -t 100 -L", | |||
"test-cov-html": "lab -a code -t 100 -L -r html -o coverage.html" | |||
"test": "node node_modules/.bin/lab -a code -t 100 -L", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those shouldn't be necessary.
2 things that bother me on this:
|
fixed but thinking about a solution for for #176 , changes will come |
@@ -2535,3 +2535,64 @@ describe('shallow()', (done) => { | |||
done(); | |||
}); | |||
}); | |||
|
|||
|
|||
describe('wrap()', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed to promiseWrap()
too.
closing in favor of #188 since it's more flexible |
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Moving .wrap to hoek as proposed by @hueniverse & @Marsup