base64 validation

[indreek]

Context

• node version: 7.0.0
• joi version: 10.0.2
• environment (node, browser):node
• used with (hapi, standalone, ...):hapi
• any other relevant information:

What are you trying to achieve or the steps to reproduce ?

{
    method: 'POST',
    path: '/account/register',
    handler: (request, reply)=>{reply('Done')},
    config: {
      description: 'Register new user account',
      validate: {
        payload: Joi.object({
          username: Joi.string().email().required(),
          password: Joi.string().base64().min(8).required()
        })
      }
    }
  }

Which result you had ?

Im sending this payload and i get response done!
{
"username": "test@test.com",
"password": "password"
}

What did you expect ?

Is there an option to validate length of decoded string? Currently password decoding returns empty string, buy Joi doesn't see problem. Maybe it should check length after decoding string? Is there such an option?

Indrek

[Marsup]

This was a bug in base64 validation, now fixed. I don't plan on making those rules interact with each other right now.

[indreek]

It doesn't understand everything.
Aa123123! = QWExMjMxMjMh
Joi says: child "password" fails because ["password" must be a valid base64 string]

[Marsup]

I reverted the patch as the previous regexp wasn't that bad after all, password is a valid base64 string, and it's not empty.