allow typ in header to be optional.

[devinstewart]

Addresses #27

typ is optional based on https://tools.ietf.org/html/rfc7519#section-5.1

[devinstewart]

ping @hapijs/tsc

Would like to get this in so that feature requests can be worked on.

Thanks as always

[cjihrig]

LGTM with a couple documentation nits.

[devinstewart]

Thanks @cjihrig, pulled in the doc nits.

[cjihrig]

Ping @hapijs/tsc for another set of eyes.

There also seems to be some issues with the CI.

[devinstewart]

Gave it the old college try. Error seems to be in the mega line in test/mock.js:

const certDer = Forge.util.encode64(Forge.asn1.toDer(Forge.pki.certificateToAsn1(Forge.pki.certificateFromPem(certPem))).getBytes());

It seems interesting to me that when breaking it out, what is happening here is that it the cert is being converted to a PEM and then back. Example code:

 const certToPem = Forge.pki.certificateToPem(cert);
 const pemToCert = Forge.pki.certificateFromPem(certToPem);
 const certDer = Forge.util.encode64(Forge.asn1.toDer(Forge.pki.certificateToAsn1(pemToCert)).getBytes());

However, when removing the back and forth with:

const certDer = Forge.util.encode64(Forge.asn1.toDer(Forge.pki.certificateToAsn1(cert)).getBytes());

I do get errors locally on 0-2 tests, each run is inconsistent. I feel if I/we can figure out what is going on there, we can perhaps remove the "flakiness" from these tests.

Just thought I would give my 2¢ in case anybody wanted to dive in.

[devinstewart]

Wasn't crazy about the solution, but it ran all 18 successfully in my local repo 5 out of 5 times. Going to let other fresh eyes take a look. I can revert what I've done here if requested.

[lloydbenson]

seems reasonable to me. I noticed this flakiness earlier but didn't get time to look into it since there was the bigger picture of getting it all moved over that took priority. Thanks for looking into this!

[Nargonath]

LGTM also