Enable linting of *.cjs and *.mjs files #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominykas
commented
Oct 13, 2022
| overrides: [ | ||
| { | ||
| files: ['*.cjs'], | ||
| parserOptions: { sourceType: 'script' } |
There was a problem hiding this comment.
This was necessary for the should lint ESM files test - now that cjs is also being scanned, the test needed an update, but it was also complaining that use strict is not necessary, because it was getting parsed as a module. TBH, I didn't have time to properly figure out why - eslint should be doing this by default for *.cjs files...
But this does unblock further improvements, I'd hope.
devinivy
approved these changes
Jan 2, 2023
|
Looks great, thanks again @dominykas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1053 - I had the code lying around, so I may as well make it public... Happy to close this if this is not useful :)