Deal with Symbol(undici.globalDispatcher.1) in Node.js 18+
#1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the failures are unrelated to my PR? |
|
@dominykas yeah, it's unrelated to your changes— I believe it's just a new typescript error behavior that we need to make lab aware of. Thanks! |
|
@devinivy actually, this is a |
Nargonath
reviewed
Dec 19, 2022
There was a problem hiding this comment.
The code LGTM, thanks @dominykas.
I'm not too fond in putting the @types/node update in this PR though. If we ever need to look at the history to find where it has been upgraded, we'd have to git bisect as it's hidden in an unrelated PR. Also for changelog purposes, it will not be shown.
|
OK, let me split that off. |
dominykas
force-pushed
the
fetch-global
branch
from
0bf579d
to
c44fac7
Compare
Nargonath
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
LGTM, thanks @dominykas for creating a new PR with the @types/node bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at it - fixes #1056.
Happy to re-do, if there's smarter options.