Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Makefile and advice about it. Closes #284. #308

Merged
merged 2 commits into from Feb 16, 2015

Conversation

@Marsup
Copy link
Member

Marsup commented Feb 16, 2015

No description provided.

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Feb 16, 2015

+1 for getting rid of Makefiles. My only comment is that I'm not sure we need to worry about node 0.11 anymore. I think we were just testing it to make sure we were ready for the 0.12 release.

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Feb 16, 2015

Node 0.11 has been out for a long time and I expect some companies to keep running it for a while, and it doesn't hurt having it, feel free to remove it though :)

@geek geek added the dependency label Feb 16, 2015
@geek geek self-assigned this Feb 16, 2015
@geek geek added this to the 5.2.2 milestone Feb 16, 2015
geek added a commit that referenced this pull request Feb 16, 2015
 Remove Makefile and advice about it. Closes #284.
@geek geek merged commit 9e985b1 into hapijs:master Feb 16, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Marsup Marsup deleted the Marsup:makefile branch Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.