Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Makefile and advice about it. Closes #284. #308

Merged
merged 2 commits into from
Feb 16, 2015

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Feb 16, 2015

No description provided.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 16, 2015

+1 for getting rid of Makefiles. My only comment is that I'm not sure we need to worry about node 0.11 anymore. I think we were just testing it to make sure we were ready for the 0.12 release.

@Marsup
Copy link
Contributor Author

Marsup commented Feb 16, 2015

Node 0.11 has been out for a long time and I expect some companies to keep running it for a while, and it doesn't hurt having it, feel free to remove it though :)

@geek geek added the dependency Update module dependency label Feb 16, 2015
@geek geek self-assigned this Feb 16, 2015
@geek geek added this to the 5.2.2 milestone Feb 16, 2015
geek added a commit that referenced this pull request Feb 16, 2015
 Remove Makefile and advice about it. Closes #284.
@geek geek merged commit 9e985b1 into hapijs:master Feb 16, 2015
@Marsup Marsup deleted the makefile branch December 18, 2015 19:42
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependency Update module dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants