Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test entire node range before bypassing #622

Merged
merged 1 commit into from Aug 15, 2016

Conversation

@jedireza
Copy link
Contributor

jedireza commented Aug 14, 2016

I found a new case where, even with #620, we could be bypassing code that should be covered. The fix is to test that the node's full range is in the bypass object.

@geek geek added the bug label Aug 15, 2016
@geek geek added this to the 11.0.0 milestone Aug 15, 2016
@geek geek self-assigned this Aug 15, 2016
@geek geek merged commit 362fc39 into hapijs:master Aug 15, 2016
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jedireza jedireza deleted the jedireza:validate-bypass-range branch Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.