Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node.js and WebStorm debuggers #673

Merged
merged 1 commit into from Jan 21, 2017

Conversation

@Marsup
Copy link
Member

Marsup commented Jan 20, 2017

Probably fixes #651.

Read the readme to see how it works. I'm not using VS Code and have no idea how it works, so if you want it, feel free to contribute.

@Marsup Marsup added the feature label Jan 20, 2017
@Marsup Marsup requested review from geek and cjihrig Jan 20, 2017
@Marsup Marsup force-pushed the inspect branch from 851f2bf to 009039e Jan 20, 2017
@geek

This comment has been minimized.

Copy link
Member

geek commented Jan 20, 2017

@Marsup !!! looks great. Any chance to add a test, even to see if it just opens the inspector port ?

@geek geek added this to the 12.0.1 milestone Jan 20, 2017

**lab** can be started with the option `--inspect` which will run it with the Node.js native debugger enabled, breaking on the 1st instruction.

This debugger can be accessed using the URL that is printed in the console, or used in association with a few Chrome extensions ([Node.js V8 Inspector](https://chrome.google.com/webstore/detail/nodejs-v8-inspector/lfnddfpljnhbneopljflpombpnkfhggl), [NIM](https://chrome.google.com/webstore/detail/nim-node-inspector-manage/gnhhdgbaldcilmgcpfddgdbkhjohddkj/related), ...).

This comment has been minimized.

Copy link
@cjihrig

cjihrig Jan 21, 2017

Contributor

Instead of ..., maybe say etc.


As you may know, if your tests are associated with the command `npm test`, you can already run `npm test -- --inspect` to run it with the inspector and avoid creating another command.

**lab** also has automatic support for [WebStorm](https://www.jetbrains.com/webstorm/) debugger, just start a normal debugging session on your npm test script.

This comment has been minimized.

Copy link
@cjihrig

cjihrig Jan 21, 2017

Contributor

Add "the" before WebStorm.

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Jan 21, 2017

Any chance to add a test, even to see if it just opens the inspector port ?

If Node is started with the debugger, there are some endpoints you can hit over HTTP to verify that it's running. For example, http://localhost:9229/json/list.

Copy link
Contributor

cjihrig left a comment

LGTM pending a test.

@geek geek merged commit bb6cc54 into master Jan 21, 2017
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the inspect branch Jan 21, 2017
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Jan 21, 2017

Sorry I'm gone for the weekend, maybe when I come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.