Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only is no longer limited to 1 test #846

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Only is no longer limited to 1 test #846

merged 2 commits into from
Oct 23, 2018

Conversation

geek
Copy link
Member

@geek geek commented Jul 29, 2018

No description provided.

@geek geek added the breaking changes Change that can breaking existing code label Jul 29, 2018
@geek geek added this to the 16.0.0 milestone Jul 29, 2018
@geek geek requested a review from Marsup July 29, 2018 18:55
@geek geek removed this from the 16.0.0 milestone Aug 21, 2018
@geek geek added the feature New functionality or improvement label Oct 23, 2018
@geek geek self-assigned this Oct 23, 2018
@geek geek added this to the 17.0.0 milestone Oct 23, 2018
cjihrig
cjihrig reviewed Oct 23, 2018
View reviewed changes
test/index.js Outdated Show resolved Hide resolved
@geek geek removed the request for review from Marsup October 23, 2018 20:21
@geek geek merged commit aea2530 into hapijs:master Oct 23, 2018
@geek geek deleted the only branch October 23, 2018 20:21
@Marsup
Copy link
Contributor

Marsup commented Oct 24, 2018

Did it work after all?

@geek
Copy link
Member Author

geek commented Oct 24, 2018

yes, you can have multiple only's at different levels and everything else is skipped.

@Marsup
Copy link
Contributor

Marsup commented Oct 24, 2018

When we discussed it a few months back, I mentioned a bug, it's still present unless I misunderstood the feature. You can see it with hapijs/joi@da9355e, it runs no test at all.

@geek
Copy link
Member Author

geek commented Oct 24, 2018

There is a bug in having multiple onlys across scripts... however, multiple onlys in a single script does work now.

@geek
Copy link
Member Author

geek commented Oct 24, 2018

@Marsup here is a fix: #867

@Marsup
Copy link
Contributor

Marsup commented Oct 24, 2018

Seems to work, superb! I'm not sure about those test failures but it fixes my case.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

@geek geek

Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Projects
None yet
Milestone
17.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@geek @Marsup @cjihrig