Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only is no longer limited to 1 test #846

Merged
merged 2 commits into from Oct 23, 2018
Merged

Only is no longer limited to 1 test #846

merged 2 commits into from Oct 23, 2018

Conversation

@geek
Copy link
Member

geek commented Jul 29, 2018

No description provided.

@geek geek added this to the 16.0.0 milestone Jul 29, 2018
@geek geek requested a review from Marsup Jul 29, 2018
@geek geek removed this from the 16.0.0 milestone Aug 21, 2018
@geek geek added the feature label Oct 23, 2018
@geek geek self-assigned this Oct 23, 2018
@geek geek added this to the 17.0.0 milestone Oct 23, 2018
test/index.js Outdated Show resolved Hide resolved
@geek geek removed the request for review from Marsup Oct 23, 2018
@geek geek merged commit aea2530 into hapijs:master Oct 23, 2018
1 of 2 checks passed
1 of 2 checks passed
Node Security nsp check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek geek deleted the geek:only branch Oct 23, 2018
@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Oct 24, 2018

Did it work after all?

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Oct 24, 2018

yes, you can have multiple only's at different levels and everything else is skipped.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Oct 24, 2018

When we discussed it a few months back, I mentioned a bug, it's still present unless I misunderstood the feature. You can see it with hapijs/joi@da9355e, it runs no test at all.

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Oct 24, 2018

There is a bug in having multiple onlys across scripts... however, multiple onlys in a single script does work now.

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Oct 24, 2018

@Marsup here is a fix: #867

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Oct 24, 2018

Seems to work, superb! I'm not sure about those test failures but it fixes my case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.