Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass remoteAddress when injecting request #306

Merged
merged 1 commit into from Jul 10, 2020
Merged

fix: pass remoteAddress when injecting request #306

merged 1 commit into from Jul 10, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Apr 6, 2020

Resolves #305

remoteAddress was not passed to server.inject() resulting in always getting 127.0.0.1 in request.info.remoteAddress in the route handler.

@air1one
Copy link
Contributor Author

air1one commented Apr 24, 2020

Hey tagging you @hueniverse if you can have a look at this, thanks !

@faustbrian
Copy link

@hueniverse any chance to get this reviewed?

@hueniverse hueniverse merged commit a93fa76 into hapijs:master Jul 10, 2020
@hueniverse hueniverse self-assigned this Jul 10, 2020
@hueniverse hueniverse added the bug Bug or defect label Jul 10, 2020
@hueniverse hueniverse added this to the 12.0.3 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hueniverse hueniverse

Labels
bug Bug or defect
Projects
None yet
Milestone
12.0.3
Development

Successfully merging this pull request may close these issues.

request.info.remoteAddress is always 127.0.0.1 in request handler
3 participants
@air1one @faustbrian @hueniverse