Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate 'close' events #26

Merged
merged 1 commit into from
Jul 5, 2020
Merged

fix duplicate 'close' events #26

merged 1 commit into from
Jul 5, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 1, 2020

This commit ensures that the stream only emits the 'close' event
once consistently across Node 12 and 14 without version detection.

@cjihrig
fix duplicate 'close' events
fed0249 
This commit ensures that the stream only emits the 'close' event
once consistently across Node 12 and 14 without version detection.
@cjihrig cjihrig mentioned this pull request Jul 1, 2020
Closed
@hueniverse
Copy link
Contributor

Thanks!

@hueniverse hueniverse self-assigned this Jul 5, 2020
@hueniverse hueniverse added the bug Bug or defect label Jul 5, 2020
@hueniverse hueniverse added this to the 4.0.2 milestone Jul 5, 2020
@hueniverse hueniverse merged commit 6dceb13 into hapijs:master Jul 5, 2020
@cjihrig cjihrig deleted the close branch July 6, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hueniverse hueniverse

Labels
bug Bug or defect
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@cjihrig @hueniverse