Testing Updates

[arb]

• Update to lab 5
• Update to code 1
• Add -a code to the Makefile
• Add -L to the Makefile

[AdriVanHoudt]

• replace Makefile with npm scripts?

[johnbrett]

Hey guys, is there any more work needed on this to close it? I can replace is the makefile with npm scripts if it's wanted?

[AdriVanHoudt]

It was mentioned somewhere to do this (can't find it anymore) also you might want to add -L to all test cases not only test-cov?

[johnbrett]

@AdriVanHoudt I don't know if there's any consensus on whether npm scripts or Makefiles are used - I don't mind either way, happy to go with npm scripts if that's what's preferred. I checked the other repos and it's near on 50/50 whether they use a Makefile or not so I don't see any pattern, does it come down to the module maintainer in that case @chrisdickinson?

[AdriVanHoudt]

@johnbrett maybe someone else can find the issue but I think the other 50% is just not updated yet but idd let's wait for maintainer to give a (no) go

[lloydbenson]

I think it was this:

outmoded/hapi-contrib#14

[AdriVanHoudt]

@lloydbenson jup that was it thanks!

[johnbrett]

Ok I replaced the Makefile with npm scripts, thanks @AdriVanHoudt @lloydbenson!

[chrisdickinson]

This should be resolved as of v1.4.2.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.