New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.2 typing inaccuracies #216
Comments
To get a correct understanding, we incorporated the DT types without any modification, was this bug already present or is it a new one? |
It must've already been present in the DT types if it was a straight copy. I don't use DT types as they can be a bit flakey and slow to catch up so tend to rely on those provided by the libraries themselves, hence why it's only become apparent for us in this latest release. |
Struggling with the same problem from 7.0.2 |
Is it better now? |
Seems it works fine right now, thanks :) |
Support plan
Context
What are you trying to achieve or the steps to reproduce?
Our application maintains a list of plugins with the type
ServerRegisterPluginObject<T, D>[]
which the default export of @hapi/vision adheres to.The recent typing additions however has the default export as a
Plugin
rather than a wrapped object. The correct typing should resemble something like @hapi/inert where thePlugin
type is wrapped.What was the result you got?
Incorrect typing. Worked around with
@ts-ignore
.What result did you expect?
Accurate typing.
The text was updated successfully, but these errors were encountered: