Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct exported types #217

Merged
merged 1 commit into from Aug 4, 2023
Merged

fix: correct exported types #217

merged 1 commit into from Aug 4, 2023

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Aug 4, 2023

Fixes #216.

Hi @damusix, it seems your types from #214 are more correct and I had totally forgottent that this PR was opened when I merged mine. I have ported your PR into this one and set you as coauthor of the commit, fixing the lab issue I mentioned in the #214. Thanks for your contribution!

@Marsup Marsup added the types TypeScript type definitions label Aug 4, 2023
@Marsup Marsup added this to the 7.0.3 milestone Aug 4, 2023
@Marsup Marsup self-assigned this Aug 4, 2023
@Marsup Marsup merged commit dfebf30 into master Aug 4, 2023
18 checks passed
@Marsup Marsup deleted the fix/types branch August 4, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.0.2 typing inaccuracies
2 participants