Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-cut failing #647

Closed
IanSmallshire opened this issue Jul 15, 2021 · 3 comments
Closed

ld-cut failing #647

IanSmallshire opened this issue Jul 15, 2021 · 3 comments

Comments

@IanSmallshire
Copy link
Collaborator

Command run below with filenames removed:

Maybe related to #645

ian@ian-ddd230:/media/ian/NAS/Banana1/Kal$ ld-cut Infile.lds outfile -s 2400 -l 100 --pal
Traceback (most recent call last):
File "/usr/local/bin/ld-cut", line 102, in
ldd = LDdecode(filename, None, loader, system=system, doDOD=False, _logger=logger)
File "/usr/local/lib/python3.8/dist-packages/lddecode/core.py", line 3233, in init
self.rf = RFDecode(
File "/usr/local/lib/python3.8/dist-packages/lddecode/core.py", line 328, in init
deemp_low, deemp_high = extra_options["deemp_coeff"]
KeyError: 'deemp_coeff'
ian@ian-ddd230:/media/ian/NAS/Banana1/Kal$ ld-cut --help
usage: ld-cut [-h] [-s start] [-l length] [-S seek] [-E end] [-p] [-n] [-C LDFCOMP] infile outfile

@atsampson
Copy link
Collaborator

We should have a test for ld-cut in the testsuite to catch this kind of thing...

Mikewando added a commit to Mikewando/ld-decode that referenced this issue Jul 15, 2021
At least restores functionality for happycube#647 (though it doesn't add a test)
@IanSmallshire
Copy link
Collaborator Author

Confirmation that this is fixed and I have now cut the file.
Is this now left open for a test to be added?

@happycube
Copy link
Owner

Yeah, there should be an added test for ld-cut. This could be closed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants