Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deemp_low and deemp_high CLI parameters #645

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

Mikewando
Copy link
Contributor

No description provided.

@Mikewando
Copy link
Contributor Author

ld-decode stores these parameters in "deemp_coeff"

"deemp_coeff": (args.deemp_low, args.deemp_high),

So of course this mismatch could also be fixed by changing how ld-decode stores them to match how core.py expects them, but that seemed like it might still require core.py changes since I think you could end up with 0 as the default value for both, which is clearly not intended.

@happycube happycube merged commit 949d319 into happycube:master Jul 6, 2021
@happycube
Copy link
Owner

Thanks!

@Mikewando Mikewando deleted the patch-1 branch July 6, 2021 05:38
@IanSmallshire IanSmallshire mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants