Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added first and last fieldNumber to the videoParameters metadata #444

Merged
merged 2 commits into from
Jan 27, 2020

Conversation

simoninns
Copy link
Collaborator

@simoninns simoninns commented Jan 26, 2020

Added some psuedo videoParameters to the LdDecodeMetaData class to provide the first and last active frame/field numbers. This is set automatcally according to the isSourcePal flag.

The idea is to only have these constants in one place which I think will help towards issue #401

@simoninns
Copy link
Collaborator Author

Let me know if I missed any... I think I found all of the instances.

Copy link
Collaborator

@atsampson atsampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible as a starting point. A couple of suggestions:

  • Add a comment describing the semantics of these variables in the LdDecodeMetaData header: "These are half-open ranges, where lines are numbered sequentially from 0 within each field or interlaced frame." Some parts of the code, e.g. the display in ld-analyse and SourceVideo::getVideoField, currently use 1-based sequential field/frame line numbers and/or closed ranges... and the standard PAL/NTSC numbering system uses 1-based numbers with the fields not interleaved, which is different again.

  • Copy over the comments from comb.h and palcolour.h saying where these numbers came from and how they map to the standard PAL/NTSC line numbers (the "Interlaced line ..." ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants