Use VideoParameters::first/lastActiveFrameLine directly in more places #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because VideoParameters used to only contain the horizontal active region bounds, several ld-chroma-decoder classes used to maintain their own idea of the vertical bounds. Now that VideoParameters contains the vertical bounds, this isn't needed any more. SourceField's helpers to compute field lines are still needed because the active lines can be different for the two fields.
For findPotentialReplacementLine, reorder the arguments to keep the output at the end.
atsampson
added
enhancement
ld-decode-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #444, it's now possible to simplify ld-chroma-decoder's active region handling quite a bit -- the classes that used to keep track of the active region can just use the VideoParameters object they already have. Ditto for one place in ld-dropout-correct.