Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add third arguments params #1591

Merged
merged 2 commits into from
Sep 18, 2016
Merged

Add third arguments params #1591

merged 2 commits into from
Sep 18, 2016

Conversation

noopnik
Copy link
Contributor

@noopnik noopnik commented Sep 8, 2016

Fixes #1586

Changes proposed in this pull request:

  • Add third argument params.

@noopnik noopnik changed the title Add third arguments params in default switch case in get_denyfn func… Add third arguments params Sep 8, 2016
@baudehlo
Copy link
Collaborator

I kind of think the constants.ok (else part) probably should be passed the params object too. Probably not useful at all, but it keeps things consistent.

@msimerson
Copy link
Member

LGTM

@msimerson msimerson merged commit ca36e90 into haraka:master Sep 18, 2016
@noopnik noopnik deleted the 1586-custom-delay-params-undefined branch September 19, 2016 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noopnik @baudehlo @msimerson