Add third arguments params #1591

Merged
merged 2 commits into from Sep 18, 2016

Conversation

Projects
None yet
3 participants
@streamtOtO
Contributor

streamtOtO commented Sep 8, 2016

Fixes #1586

Changes proposed in this pull request:

  • Add third argument params.

@streamtOtO streamtOtO changed the title from Add third arguments params in default switch case in get_denyfn func… to Add third arguments params Sep 8, 2016

@msimerson msimerson added the Bug Fix label Sep 9, 2016

@baudehlo

This comment has been minimized.

Show comment
Hide comment
@baudehlo

baudehlo Sep 10, 2016

Collaborator

I kind of think the constants.ok (else part) probably should be passed the params object too. Probably not useful at all, but it keeps things consistent.

Collaborator

baudehlo commented Sep 10, 2016

I kind of think the constants.ok (else part) probably should be passed the params object too. Probably not useful at all, but it keeps things consistent.

@msimerson

This comment has been minimized.

Show comment
Hide comment
@msimerson

msimerson Sep 13, 2016

Member

LGTM

Member

msimerson commented Sep 13, 2016

LGTM

@msimerson msimerson merged commit ca36e90 into haraka:master Sep 18, 2016

2 checks passed

codecov/project 35.93% remains the same compared to f2b2fa4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@streamtOtO streamtOtO deleted the streamtOtO:1586-custom-delay-params-undefined branch Sep 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment