remove old plugins, notify users to update config #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 35.97% (diff: 100%)@@ master #1681 diff @@
==========================================
Files 24 24
Lines 6076 6076
Methods 785 785
Messages 0 0
Branches 1536 1536
==========================================
Hits 2186 2186
Misses 3890 3890
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with #1645
background: In #1645, I left behind the old plugins so that upgraders would not get a CRIT when starting Haraka due to the missing plugin. That would happen because the old plugin names were
connect.asnandconnect.geoip. The new plugin names areharaka-plugin-asnandharaka-plugin-geoip, but are referred to in config/plugins as justasnandgeoip.Changes proposed in this pull request: