Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_base.js: Replace string concatenations with template literal #2252

Merged
merged 7 commits into from
Oct 24, 2017

Conversation

hontas
Copy link
Contributor

@hontas hontas commented Oct 23, 2017

Fixes #2129

Changes proposed in this pull request:

  • Replace string concatenations with template literal

Checklist:

  • [-] docs updated
  • [-] tests updated
  • [-] Changes updated

@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #2252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2252   +/-   ##
=======================================
  Coverage   59.36%   59.36%           
=======================================
  Files          28       28           
  Lines        6059     6059           
  Branches     1501     1501           
=======================================
  Hits         3597     3597           
  Misses       2462     2462

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2637fd4...74ab771. Read the comment docs.

Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimerson msimerson merged commit 63b7f91 into haraka:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants