Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postinstall script fails on Windows 7 #205

Closed
Diorbert opened this issue Jul 31, 2017 · 6 comments
Closed

Postinstall script fails on Windows 7 #205

Diorbert opened this issue Jul 31, 2017 · 6 comments

Comments

@Diorbert
Copy link

Diorbert commented Jul 31, 2017

I'm trying to install ohm-js on Windows 7, but fails with the following error:

ohm-js@0.13.1 postinstall: `bash bin/postinstall`

Failed at the ohm-js@0.13.1 postinstall script 'bash bin/postinstall'.
Make sure you have the latest version of node.js and npm installed.

I checked the Issues History and found the Issue #42 , which treated the same problem, but didn't solved to me.

@thisiskell
Copy link

I am running into the same issue.

@mniebling
Copy link

Would you be open to implementing the npm postinstall functionality with Node scripts instead? As described in this thread I think this would get you the best portability.

Since it looks like the main goal of the postinstall hook is to add a git hook for developers, perhaps using husky as a devDependency might also be an option? I've had good results with that, although mainly for simple "precommit: npm test" type hooks.

@pdubroy
Copy link
Contributor

pdubroy commented Aug 2, 2017

Since none of the core developers are using Windows, I'd be happy to take a PR that will fix these problems (as long as the solution isn't too complicated, that is).

@mniebling: Moving to Husky seems like it might be a good idea. Would you like to submit a PR?

@mniebling
Copy link

Yes, I'm happy to take a look at this. We're using Ohm at work and our dev machines are a mix of OS so I should be able to get some free testers 😄

@pdubroy
Copy link
Contributor

pdubroy commented Aug 2, 2017

Great, thanks! BTW I'd love to hear what you are using Ohm for; feel free to email me privately (address is in my profile).

@Diorbert
Copy link
Author

Diorbert commented Aug 2, 2017

Good to know that I am not the only one still with this problem, but I would like to share something. I was able to work around the problem by installing a linux terminal emulator (cmder). With that it worked for me. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants