Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

old CAN.py #267

Closed
felixdivo opened this issue Feb 23, 2018 · 3 comments
Closed

old CAN.py #267

felixdivo opened this issue Feb 23, 2018 · 3 comments
Labels
api
Milestone
2.2 Release

Comments

@felixdivo
Copy link
Collaborator

Maybe we should print a deprecation warning when importing CAN.py, and say when (or at least that) it will get removed.

At the top you can find that info: This API is left intact for version 2.0 to aide with migration.. So I guess, that at one point it will get removed, right?
@felixdivo felixdivo added the api label Feb 23, 2018
@felixdivo felixdivo added this to the 2.2 Release milestone Feb 23, 2018
@hardbyte
Copy link
Owner

Sounds good. Maybe lets add the warning now for release 2.2. We could upgrade the warning to be a bit more severe for 2.3 then remove in 2.4

@felixdivo
Copy link
Collaborator Author

Ok, I'll add the warning.

@hardbyte
Copy link
Owner

Great. Next update should use the warnings stdlib module - https://docs.python.org/3.6/library/warnings.html#warnings.warn

boris-wenzlaff pushed a commit to boris-wenzlaff/python-can that referenced this issue Mar 23, 2018
@felixdivo
warn about usage of the old CAN module. fix hardbyte#267
395bf83
@hardbyte hardbyte mentioned this issue Jun 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
2.2 Release
Development

No branches or pull requests
2 participants
@hardbyte @felixdivo