Merge develop into master for release 2.2.0 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: Synchronized bus instance & (on the side) Fixes/Cleanups in Socketcan
Changes the semantics of can_filters==[] to reflect what the buses are doing
* Adding proper bitrate and timestamp support for neovi * Update the requirement for the python-ics version to 2.12 * Removing dead code
Will only keep logging the error that ICS lib consider critical and no longer raise them. In most case, the error is affecting the accuracy but the device can still be use normally (i.e. Rx buffer overflow). In these cases, we do not want for example to kill a notifier using this bus, etc.
Make Notifier support multiple buses Add support for channels in more formats, interfaces, and loggers
Also support broadcast channel
* Get travis CI to build the sphinx docs * Various documentation updates (primarily to minimize sphinx warnings) * Pypy is having issues with building sphinx docs so just build for python 3.6 * Enabled nitpick mode, but not turn warnings into errors Closes #340
felixdivo
approved these changes
Jun 29, 2018
|
How do we list the changes in the individual interfaces? There are changes that might be interesting for some, like setting bitrate was added and alike. |
hardbyte
changed the title
|
Looks good 👍 |
|
Hey @hardbyte, shouldn't successful AppVeyor tests also be required to be able to merge into master?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly impressive list of features went in to this release - https://github.com/hardbyte/python-can/milestone/3?closed=1
Please help me edit this PR to make the changelog.
Changelog
Major Features
socketcan_nativeandsocketcan_ctypes), this is now completely transparent for the library user. Merge socketcan_native and socketcan_ctypes into one #326Removals
CANmodule, please use the newercanentry point (will be removed in version 2.4). old CAN.py #267Interface Specific Changes
There were many changes and a lot of cleanup effort in the individual interfaces. Some of the highlights:
SocketCAN
socketcanin the future instead ofsocketcan_nativeorsocketcan_ctypesMerge socketcan_native and socketcan_ctypes into one #326Vector
PCAN
Use configured bitrate. #254
USB2CAN
Show stopping bug #219 has been fixed.
Minor Changes
can.Notifieraddingadd_listenerandremove_listenermethods can.Notifier enhancements #266SqlReaderandSqlWriterhave been renamed toSqliteReaderandSqliteWriter. add a deprecated notice to 'SqlReader' for users #263Try it out from PyPi: