Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCReader: Fix error for DLC > 8 #1301

Merged
merged 1 commit into from Jun 7, 2022
Merged

Conversation

zariiii9003
Copy link
Collaborator

Closes #1299

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1301 (638d81a) into develop (638d81a) will not change coverage.
The diff coverage is n/a.

❗ Current head 638d81a differs from pull request most recent head 9160f45. Consider uploading reports for the commit 9160f45 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1301   +/-   ##
========================================
  Coverage    66.03%   66.03%           
========================================
  Files           86       86           
  Lines         8917     8917           
========================================
  Hits          5888     5888           
  Misses        3029     3029           

@zariiii9003 zariiii9003 added bug file-io about reading & writing to files labels Apr 29, 2022
@zariiii9003 zariiii9003 added this to the 4.0.1 milestone Apr 29, 2022
@zariiii9003
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

rebase

✅ Branch has been successfully rebased

@zariiii9003 zariiii9003 merged commit 0c4dee0 into hardbyte:develop Jun 7, 2022
@zariiii9003 zariiii9003 deleted the fix_1299 branch June 7, 2022 06:50
@felixdivo felixdivo modified the milestones: 4.0.1, 4.1.0 Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug file-io about reading & writing to files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asc file parse failed
3 participants