Fix fileno error on Windows (Serial bus) #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change implemented similar to that made in hardbyte#1313. This means notifiers will now work with the Serial interface.
Codecov Report
@@ Coverage Diff @@
## develop #1333 +/- ##
===========================================
- Coverage 65.92% 59.48% -6.45%
===========================================
Files 86 86
Lines 8955 8866 -89
===========================================
- Hits 5904 5274 -630
- Misses 3051 3592 +541 |
|
Thank you! Could you undo the Readme changes? The conda-forge version seems unmaintained. |
This reverts commit 59d0b3c.
|
Sorry @zariiii9003, I have reverted the readme change. That must have snuck in when I rebased my local repository. I made a pull request to the conda-forge feedstock repository some time ago, but as you noted it appears to be unmainained. |
zariiii9003
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues with the Async example from the docs using the Serial interface:
io.UnsupportedOperation: filenoI looked back through the issues and found that several people have hit the fileno error over the years (#760, #877, #902). I have implemented the most recent fix from #1313 on the serial_bus.py interface and added a test case to the test_serial.py file.