Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default fileno function to the BusABC #877

Merged
merged 5 commits into from
Aug 4, 2020

Conversation

hardbyte
Copy link
Owner

Modify Notifier to handle the exception raised if the bus doesn't override it.

… handle the exception raised if the bus doesn't override it.
can/notifier.py Outdated Show resolved Hide resolved
@bmeisels
Copy link
Contributor

bmeisels commented Aug 3, 2020

Looks good. I would like to make a followup change to slcan which will raise NotImplementedError on windows (which was the original motivation for this change).

@hardbyte hardbyte added this to the 4.0 Release milestone Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #877 into develop will increase coverage by 0.02%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
+ Coverage    70.69%   70.71%   +0.02%     
===========================================
  Files           71       71              
  Lines         6909     6915       +6     
===========================================
+ Hits          4884     4890       +6     
  Misses        2025     2025              

@hardbyte hardbyte merged commit ac6e3ef into develop Aug 4, 2020
@hardbyte hardbyte deleted the feature-add-fileno-to-busabc branch October 19, 2020 19:28
@felixdivo felixdivo changed the title Add a default fileno function to the BusABC class. Add a default fileno function to the BusABC Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants