Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __del__ method to BusABC #1489

Merged
merged 25 commits into from
Mar 30, 2023
Merged

Add __del__ method to BusABC #1489

merged 25 commits into from
Mar 30, 2023

Conversation

Tbruno25
Copy link
Contributor

@Tbruno25 Tbruno25 commented Jan 17, 2023 •
edited by felixdivo
Loading

Initial PR to address #1448

Closes #1448

Tbruno25
Tbruno25 commented Jan 17, 2023
View reviewed changes
can/bus.py Outdated Show resolved Hide resolved
@Tbruno25 Tbruno25 force-pushed the tj/1488_use-del branch 2 times, most recently from 43d6418 to 7f028d6 Compare January 17, 2023 04:54
@felixdivo felixdivo added this to the Next Release milestone Jan 22, 2023
@felixdivo felixdivo added the api label Jan 22, 2023
felixdivo
felixdivo reviewed Jan 22, 2023
View reviewed changes
can/bus.py Outdated Show resolved Hide resolved
felixdivo
felixdivo reviewed Jan 22, 2023
View reviewed changes
can/bus.py Outdated Show resolved Hide resolved
TJ Bruno and others added 7 commits January 23, 2023 14:38
Add del method
a615878
Add unittest
f9ebbac
Satisfy black formatter
60cb71b
Satisfy pylint linter
9b0587d
@Tbruno25 @felixdivo
PR feedback
545c2f4 
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
@Tbruno25 @felixdivo
PR feedback
16fd7b9 
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
Move to cls attribute
90a29da
felixdivo
felixdivo reviewed Jan 24, 2023
View reviewed changes
can/bus.py Outdated Show resolved Hide resolved
@felixdivo felixdivo added the bug label Jan 24, 2023
@felixdivo
Copy link
Collaborator

I added the bug label since now, for example, etas properly calls stop_all_periodic_tasks() on shutdown.

Tbruno25 and others added 3 commits January 25, 2023 11:18
@Tbruno25 @felixdivo
PR feedback
468db05 
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
Remove try/except & fix ordering
692b2e5
Fix unittest
c0d5ae1
felixdivo
felixdivo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'll have to check if pytest.mark.filterwarnings is really a good idea, and not hiding any other problems. Else, this can be merged.

@felixdivo felixdivo mentioned this pull request Jan 31, 2023
Closed
@felixdivo
Copy link
Collaborator

I'll have to check if pytest.mark.filterwarnings is really a good idea

Hey @Tbruno25, would you mind commenting on whether #1519 is a good idea?

@zariiii9003
Copy link
Collaborator

@felixdivo i cherry-picked your changes and fixed the AttributeError. Would you like to take another look?

felixdivo
felixdivo approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Didn't test it locally, but you probably did and we have good unit tests on this. Nice work! 🥳

@zariiii9003 zariiii9003 merged commit 7855da1 into hardbyte:develop Mar 30, 2023
@Tbruno25 Tbruno25 deleted the tj/1488_use-del branch March 30, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdivo felixdivo felixdivo approved these changes

Assignees

@Tbruno25 Tbruno25

Labels
api bug
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

Consider using __del__
3 participants
@Tbruno25 @felixdivo @zariiii9003