Export symbols to satisfy type checkers #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdivo
approved these changes
Mar 30, 2023
|
@felixdivo Thanks for taking a look. Coveralls is failing, that's a new one |
|
@tjohanssonn Could you try this branch with pyright? |
|
@zariiii9003 Sorry for the delay. I've tested the branch and it seems to be working! Thanks for the quick attention and fix. Only issue that remains now is the:
But that was not part of my issue #1547, so that issue is ✅ |
This was referenced Apr 4, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1547
This also introduces ruff with isort, pyupgrade and the unused-imports check.
@felixdivo The version with the
import x as xreexport can be seen here. I think that one is less ugly, but i don't care too much.