Fix ASCWriter millisecond handling #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumagi
force-pushed
the
fix_asc_msec_handling
branch
from
84386ed
to
31cbda8
Compare
lumagi
force-pushed
the
fix_asc_msec_handling
branch
from
31cbda8
to
160cea8
Compare
|
Supposed to fix part of the problem presented in #1699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I would like to improve the string formatting of milliseconds in the
ASCWriterclass.Unfortunately, the format seems to rely on localized datetimes. I added a commit to change the date time format to 24h instead of 12h. Let me know what you think.