Sync #1
Merged
Sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a read-only computed property.
… superentity with a custom class, to handle Swift rules for including "override" in method declarations.
…l not be inserted for class methods of top-level entities unless the new template var "overrideBaseClass" is used.
Xcode omits the optional attribute in its XML model output if it is set to not-optional, but `NSPropertyDescription.optional` defaults to YES. To be on the safe side I decided to treat all Booleans the same. Currenlty only optional was affected, because it's the only attribute which default is YES. That should fix issue #286
Support for additionalHeaderFileName on Feature/swift12
Add quotes around calls to `Dir.pwd` so that tests run if the path contains spaces.
Adds support for ordered relationships.
Fix swift template for ordered relationships.
…d of TMPDIR. TMPDIR is not well-defined, but DERIVED_FILE_DIR is during an Xcode build. Also, make sure paths are quoted.
Modernizing mogenerator internals.
I noticed this change while reviewing the changes in my generated files for mogenerator 1.30.
Add space between property type and name.
…ments in machine header. (Fixing #325)
[FIX] Only use `@import` if supported (which Objective-C++ does not). [issue 325](#325) ([Samuel Bichsel](https://github.com/melbic))
Because NSEntityDescription#entityForName:inManagedObjectContext: is nullable
If, during CoreDataGeneratedAccessors, a relationship property is null, fall back to a newly instantiated NSOrderedSet.
[CHANGE] Add `nullable` to `+ entityInManagedObjectContext:` to pass `-Wnullable-to-nonnull-conversion`. ([Ibrahim Sha'ath](#337))
[CHANGE] In the machine implementation of the collection properties (`insertObject:inFOOAtIndex:`, `removeObjectFromFOOAtIndex:`, `insertFOO:atIndexes:`, `removeFOOtIndexes:`, `replaceObjectInFOOAtIndex:withObject:`, `replaceFOOAtIndexes:withFOO:`) supply `+[NSMutableOrderedSet orderedSetWithOrderedSet:]` with an empty set instead of nil to to naively pass `-Wnullable-to-nonnull-conversion`. ([Ibrahim Sha'ath](#338))
A defined attribute can be nullable, so the getter and setter of the primitive should consider nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.