Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPOS] PairPos >64k expansion #38

Closed
behdad opened this issue Sep 20, 2021 · 1 comment
Closed

[GPOS] PairPos >64k expansion #38

behdad opened this issue Sep 20, 2021 · 1 comment
Labels
Implemented Implemented in HarfBuzz or doesn't need to Layout >64k expansion
Projects
BE 2.0 spec
Milestone
BE 2.0 ~= HB 5.0 ...

Comments

@behdad
Copy link
Member

behdad commented Sep 20, 2021 •
edited

The Coverage table part is covered in #30.

Two new formats are added. Format 2 is replicated just to address offset-overflow issues.

struct PosFormat3 {
  uint16 format; == 3
  Offset24To<Coverage> coverage;
  uint16 valueFormat1;
  uint16 valueFormat2;
  Array16Of<Offset24To<PairSet24>> pairSets;
};

struct PairSet24 {
  uint24 pairValueCount;
  PairValueRecord24 pairValueRecords[pairValueCount];
};

struct PairValueRecord24 {
  GlyphID24 secondGlyph;
  ValueRecord valueRecord1;
  ValueRecord valueRecord2;
};

struct PosFormat4 {
  uint16 format; == 4
  Offset24To<Coverage> coverage;
  uint16 valueFormat1;
  uint16 valueFormat2;
  Offset24To<ClassDef> classDef1;  
  Offset24To<ClassDef> classDef2;
  uint16 class1Count;
  uint16 class2Count;
  Class1Record class1Records[class1Count];
};
@behdad behdad mentioned this issue Sep 20, 2021
Closed
@behdad behdad added this to To do in BE 2.0 spec Sep 22, 2021
behdad added a commit to fonttools/fonttools that referenced this issue Jul 4, 2022
@behdad
[>64k:layout:PairPos] Implement PairPos format 3/4
25acbb5 
And merger upgrade logic.

Implements harfbuzz/boring-expansion-spec#38
behdad added a commit to fonttools/fonttools that referenced this issue Jul 4, 2022
@behdad
[>64k:layout:PairPos] Implement PairPos format 3/4
ac02787 
And merger upgrade logic.

Implements harfbuzz/boring-expansion-spec#38
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 7, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
0c1c2d8 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 7, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
327e154 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 7, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
ec0ca22 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 7, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
a2c73c8 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
54d8b6b 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
77eae97 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
ba17723 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
2d9e6df 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
be58b05 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to fonttools/fonttools that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Implement PairPos format 3/4
8ce9866 
And merger upgrade logic.

Implements harfbuzz/boring-expansion-spec#38
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
2b4419c 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 8, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
43880af 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 11, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
a4e90ff 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 11, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
7089b5d 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 12, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
9841625 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 12, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
864b615 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
@behdad behdad added the Implemented Implemented in HarfBuzz or doesn't need to label Jul 12, 2022
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 12, 2022
@behdad
[>64k:layout:PairPos] Templatize & implement format 4
e9f8010 
Implements part of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Jul 12, 2022
@behdad
[>64k:layout:PairPos] Implement format 3
f0d6dda 
Implements rest of harfbuzz/boring-expansion-spec#38

Subset does NOT lower format.
behdad added a commit to fonttools/fonttools that referenced this issue Jul 12, 2022
@behdad
[>64k:layout:PairPos] Implement PairPos format 3/4
019246b 
And merger upgrade logic.

Implements harfbuzz/boring-expansion-spec#38
@behdad
Copy link
Member Author

behdad commented Mar 6, 2023

Speced: https://github.com/harfbuzz/boring-expansion-spec/blob/main/beyond-64k.md
Implemented in HarfBuzz.

@behdad behdad closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Implemented Implemented in HarfBuzz or doesn't need to Layout >64k expansion
Projects
No open projects
BE 2.0 spec
To do
Milestone
BE 2.0 ~= HB 5.0 ~= 2022 ~= OT 2.0
Development

No branches or pull requests
1 participant
@behdad