Skip to content

Commit

Permalink
[>64k:layout:AlternateSubst] Implement format 2
Browse files Browse the repository at this point in the history
Implements rest of harfbuzz/boring-expansion-spec#32

Subset does NOT lower format.
  • Loading branch information
behdad committed Jul 8, 2022
1 parent 7df94dd commit 3efa669
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/OT/Layout/GSUB/AlternateSubst.hh
Expand Up @@ -14,6 +14,9 @@ struct AlternateSubst
union {
HBUINT16 format; /* Format identifier */
AlternateSubstFormat1_2<SmallTypes> format1;
#ifndef HB_NO_BORING_EXPANSION
AlternateSubstFormat1_2<MediumTypes> format2;
#endif
} u;
public:

Expand All @@ -24,10 +27,15 @@ struct AlternateSubst
if (unlikely (!c->may_dispatch (this, &u.format))) return_trace (c->no_dispatch_return_value ());
switch (u.format) {
case 1: return_trace (c->dispatch (u.format1, std::forward<Ts> (ds)...));
#ifndef HB_NO_BORING_EXPANSION
case 2: return_trace (c->dispatch (u.format2, std::forward<Ts> (ds)...));
#endif
default:return_trace (c->default_return_value ());
}
}

/* TODO This function is unused and not updated to 24bit GIDs. Should be done by using
* iterators. While at it perhaps using iterator of arrays of hb_codepoint_t instead. */
bool serialize (hb_serialize_context_t *c,
hb_sorted_array_t<const HBGlyphID16> glyphs,
hb_array_t<const unsigned int> alternate_len_list,
Expand All @@ -42,6 +50,9 @@ struct AlternateSubst
default:return_trace (false);
}
}

/* TODO subset() should choose format. */

};

}
Expand Down

0 comments on commit 3efa669

Please sign in to comment.