Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leak of post table? #1171

Closed
ebraminio opened this issue Sep 22, 2018 · 1 comment
Closed

leak of post table? #1171

ebraminio opened this issue Sep 22, 2018 · 1 comment

Comments

@ebraminio
Copy link
Collaborator

Trying to make #1169 happen,

If I apply this, hb-shape's leak (on asan) will be resolved,

diff --git a/src/hb-ot-font.cc b/src/hb-ot-font.cc
index faacecb9..9a1c2e9d 100644
--- a/src/hb-ot-font.cc
+++ b/src/hb-ot-font.cc
@@ -160,8 +160,9 @@ hb_ot_get_glyph_name (hb_font_t *font HB_UNUSED,
                       char *name, unsigned int size,
                       void *user_data HB_UNUSED)
 {
-  const hb_ot_face_data_t *ot_face = (const hb_ot_face_data_t *) font_data;
-  return ot_face->post->get_glyph_name (glyph, name, size);
+  // const hb_ot_face_data_t *ot_face = (const hb_ot_face_data_t *) font_data;
+  // return ot_face->post->get_glyph_name (glyph, name, size);
+  return false;
 }

Apparently post's fini is not called

image

Any hint?

@behdad behdad closed this as completed in d7f2177 Sep 23, 2018
@behdad
Copy link
Member

behdad commented Sep 23, 2018

I think your printf didn't print because it had no newline and process was killed before it flushed. fini() was being called. Just that it was not freeing blob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants