Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aat] Difference in WAW spacing between CoreText and HB AAT #1350

Closed
drott opened this issue Nov 2, 2018 · 6 comments
Closed

[aat] Difference in WAW spacing between CoreText and HB AAT #1350

drott opened this issue Nov 2, 2018 · 6 comments
Labels
Chrome Chrome/Chromium project related issues and requests

Comments

@drott
Copy link
Collaborator

drott commented Nov 2, 2018

Using GeezaPro from Mac OS 10.10:

CoreText

$ ../test/shaping/hb-unicode-encode U+0648,U+0644,U+064A | ./hb-shape ~/dev/geeza_pro/GeezaPro_10_10.ttc --shaper=coretext  --direction=rtl
[u064a.final.yeh.001=2+1545|u0644.initial.lam=1+353|u0648.waw=0+868]

HB AAT:

$ ../test/shaping/hb-unicode-encode U+0648,U+0644,U+064A | ./hb-shape ~/dev/geeza_pro/GeezaPro_10_10.ttc --shaper=ot --font-funcs=ot  --direction=rtl
[u064a.final.yeh.001=2+1545|u0644.initial.lam=1+515|u0648.waw=0+868]

So, HarfBuzz AAT computes a much wieder advance for u0644.initial.lam for some reason.
@drott drott added the Chrome Chrome/Chromium project related issues and requests label Nov 2, 2018
@behdad
Copy link
Member

behdad commented Nov 2, 2018

I think I'm appyling kern wrong, adding space instead of removing...

@drott
Copy link
Collaborator Author

drott commented Nov 2, 2018

Images

CoreText

waw_coretext

HB AAT

waw_ot

@behdad
Copy link
Member

behdad commented Nov 2, 2018

Thanks.

@behdad
Copy link
Member

behdad commented Nov 2, 2018

Okay, it's not kerning at all. Debugging.

@behdad
Copy link
Member

behdad commented Nov 2, 2018

Oh, it's kern table format 1. Basically, mort of the kerx.

@behdad behdad closed this as completed in 8034d1d Nov 2, 2018
@ebraminio
Copy link
Collaborator

Basically, mort of the kerx.

Hehehe. Looks much better now.

ebraminio pushed a commit to ebraminio/harfbuzz that referenced this issue Nov 24, 2018
@behdad @ebraminio
[kern] Implement Format1
039d304 
Also, implement backwards kerning for Format1 in kern and kerx.

Fixes harfbuzz#1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chrome Chrome/Chromium project related issues and requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behdad @ebraminio @drott