Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 tarball has wrong version info #1643

Closed
waywardmonkeys opened this issue Mar 29, 2019 · 9 comments
Closed

2.4 tarball has wrong version info #1643

waywardmonkeys opened this issue Mar 29, 2019 · 9 comments

Comments

@waywardmonkeys
Copy link
Contributor

This is the same sort of issue as #1271 ... the hb-version.h has a version 1.7.6, not 2.4.0

@behdad
Copy link
Member

behdad commented Mar 29, 2019

Phew. @khaledhosny you probably had a stale hb-version.h in your build or src dir?

Let's roll a new release. Khaled, do you want to do it completely yourself. I can do the fdo upload.

If we upload all past releases to github, we can remove fdo dir. Or people find it easier to (automatically) download from fdo directory than github?

@behdad
Copy link
Member

behdad commented Mar 29, 2019

So yeah, we are going to branch 2.4 and make fixup releases from.

@behdad
Copy link
Member

behdad commented Mar 29, 2019

Humm. Since the source tree is correct and this is just a tarball issue, let's just recreate the tarball and upload. @khaledhosny send me a new one. Thanks.

@behdad
Copy link
Member

behdad commented Mar 29, 2019

Either way is fine.

@khaledhosny
Copy link
Collaborator

I had the correct hb-version.h in the source tree, but the build tree had a stale one indeed (which seems to have been there for so long!). I can check the release stuff tomorrow, it is pretty late here now.

@ebraminio
Copy link
Collaborator

RIP for 2.4 :/ We may can assign a bot and use its tarball artifact

@behdad
Copy link
Member

behdad commented Mar 29, 2019

Okay don't worry. I'll take care of it here.

@behdad
Copy link
Member

behdad commented Mar 30, 2019

Also #1641 for context.

@behdad
Copy link
Member

behdad commented Mar 30, 2019

Okay, uploaded new tarball...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants