Broken distribution files for 2.4.0

[atsampson]

The distribution files for 2.4.0 on freedesktop.org that have appeared today seem to be broken - the .sha256 file is empty, and the .tar.bz2 is only 14 bytes.

[ebraminio]

No GitHub upload also.

And what has happened between 2.2.0 and 2.3.0, that looks weird.

[dscorbett]

Also, some “REPLACEME”s were missed.

[behdad]

Umm.. I've been without a Linux laptop for two months now. Tried making a release on a Mac and here we go...

I'll fix up today.

[behdad]

(Also why I have not been making win32 bundles. If anyone wants to add those, I can upload them. If anyone wants to take over release engineering, I'd appreciate that!)

[behdad]

I don't know what's wrong with my Mac setup, but I tried "make dist" again, and still get the 14-byte tarball. Can someone build the tarball for 2.4.0 commit and send it to me to sign and upload?

[behdad]

@ebraminio @dscorbett I'll wait for help from either of you. Thanks.

[behdad]

Or feel free to make a 2.4.1 release.

[khaledhosny]

I can make the tarball, but you didn’t push a tag for 2.4.0

[behdad]

I can make the tarball, but you didn’t push a tag for 2.4.0

Gah. Somehow git doesn't like to sign, even though I've set up my gpg:

error: gpg failed to sign the data
error: unable to sign the tag
The tag message has been left in .git/TAG_EDITMSG

Do the tag -s and push as well? Thanks Khaled.

[behdad]

Okay, figured out. Pushed tag.

[khaledhosny]

Tarball sent.

[ryandesign]

I don't know what's wrong with my Mac setup, but I tried "make dist" again, and still get the 14-byte tarball.

@behdad The .tar.bz2 files was 14 bytes; the .tar file inside was 0 bytes.

I tried make dist on my Mac (macOS 10.13.6, Xcode 9.4.1, dependencies installed with MacPorts) and it produced a reasonable .tar.bz2 file.

Maybe I can help you sort out what went wrong on your machine. Did you get any errors about the harfbuzz-2.4.0 directory not getting created, or any errors from tar while creating the tarball?

[behdad]

And what has happened between 2.2.0 and 2.3.0, that looks weird.

Oh. Umm yeah. I think @blueshade7 added the entirety of SourceHanSans to the repo! We should remove it. Tarball size grew from 4MB to 17MB!

@blueshade7 Please replace that with a subset. Thanks.

[behdad]

Should be fixed now. But yeah, we should remove that huge font. I wish there was an easy way to clean it up from the repo as well, but there isn't without rewriting history....