Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should dist be enabled by dfault for all scripts? #1907

Closed
khaledhosny opened this issue Aug 14, 2019 · 5 comments · Fixed by #1908
Closed

Should dist be enabled by dfault for all scripts? #1907

khaledhosny opened this issue Aug 14, 2019 · 5 comments · Fixed by #1908

Comments

@khaledhosny
Copy link
Collaborator

The Segoe UI Emoji font has a dist feature to fix some spacing issues (see khaledhosny/harftex#12 (comment)) and seems to expect it to be applied to emoji text.

HarfBuzz seems to enable it only in USE and a selected set of scripts, but Core Text seems to apply it to the emoji text is well, can’t test Uniscribe/DirectWrite at the moment.

Is dist now enabled for all scripts or does emoji gets shaped with USE now?
@dscorbett
Copy link
Collaborator

See also MicrosoftDocs/typography-issues#106.

@behdad
Copy link
Member

behdad commented Aug 14, 2019

I'm fine enabling it

@behdad
Copy link
Member

behdad commented Aug 14, 2019

But really. Segoe UI Emoji, why?

@khaledhosny
Copy link
Collaborator Author

But really. Segoe UI Emoji, why?

My guess would be because Word disables kern by default (I’d have used mark though, since mark anchors are already involved).

@behdad
Copy link
Member

behdad commented Aug 15, 2019

Right.. so using dist as required kerning basically. Let's do.

@khaledhosny khaledhosny mentioned this issue Aug 15, 2019
Merged
khaledhosny added a commit that referenced this issue Aug 15, 2019
@khaledhosny
[ot-shape] Enable dist feature by default (#1908)
2164bd6 
Fixes #1907
@khaledhosny khaledhosny mentioned this issue Feb 15, 2020
Open
@khaledhosny khaledhosny mentioned this issue Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ot-shape] Enable dist feature by default
3 participants
@khaledhosny @behdad @dscorbett