Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ArrayOf, HeadlessArrayOf, and ArrayOfM1 #1937

Closed
behdad opened this issue Aug 28, 2019 · 2 comments
Closed

Merge ArrayOf, HeadlessArrayOf, and ArrayOfM1 #1937

behdad opened this issue Aug 28, 2019 · 2 comments

Comments

@behdad
Copy link
Member

behdad commented Aug 28, 2019

While adding serialize / subset, it's frustrating to have to triplicate code...
@behdad
Copy link
Member Author

behdad commented Aug 28, 2019

We'll make the ArrayOf<> template take a couple of integer arguments that allow it to behave like other two. Need to be careful with all uses of the type though. Probably make len private and implement get_len / set_len...

behdad added a commit that referenced this issue Aug 28, 2019
@behdad
Beef up HeadlessArrayOf<>
42d887b 
Should be merged with ArrayOf...
#1937
@behdad
Copy link
Member Author

behdad commented Aug 29, 2019

Also the Sorted versions. Make sorted be a bool template parameter.

@behdad behdad mentioned this issue Aug 29, 2019
Closed
@behdad behdad closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behdad